patternfly-elements icon indicating copy to clipboard operation
patternfly-elements copied to clipboard

tools: static version property not set correctly

Open bennypowers opened this issue 2 years ago • 1 comments

Description of the issue

pfe-tools' packageVersion esbuild plugin reads the package.json version and interpolates it into each component's source code. The problem is that this appears to happen before the npm version command which actually updates the package.json version. 👀 👉 see chat thread, this may only be an issue for docs

Impacted component(s)

  • all

Steps to reproduce

  1. publish a package version

Expected behavior

el.constructor.version should match the package.json version

bennypowers avatar Feb 24 '22 22:02 bennypowers

h/t @zeroedin for the report

bennypowers avatar Feb 24 '22 22:02 bennypowers