patternfly-elements icon indicating copy to clipboard operation
patternfly-elements copied to clipboard

[fix]: [pfe-navigation 1.x] doesn't render slot="mobile-login" unless slot"mobile-language" exists.

Open ryanissamson opened this issue 5 years ago • 2 comments

Discovered in our site, pfe-navigation doesn't render slot="mobile-login" unless slot"mobile-language" exists.

Impacted component(s)

In our HTML, we have:

<a href="/login" slot="mobile-login" pfe-icon="web-user" tabindex="-1">Log in</a>

This results in the Log in link not being displayed on mobile.

But if we alter it to include:

<a href="/login" class="rh-user-loggedout" slot="mobile-login" pfe-icon="web-user" tabindex="-1">Log in</a> <a href="/url-to-language-page" slot="mobile-language" pfe-icon="web-globe">English</a> Then both links render. The issue is, our site does not have a mobile language link.

Steps to reproduce

  1. Add a slot in HTML for mobile-login only.
  2. Observe that the slot isn't used.

Expected behavior

A mobile-login link can be used by itself.

Screenshots

Screen Shot 2020-09-23 at 1 47 54 PM Screen Shot 2020-09-23 at 1 48 14 PM

ryanissamson avatar Sep 23 '20 17:09 ryanissamson

@castastrophe Hey! Any chance the linked PR that would resolve this issue will be merged in the near future?

ryanissamson avatar Feb 05 '21 20:02 ryanissamson

@ryanissamson Hey Ryan, it's on our radar but is not a high priority at the moment. If you would like to advocate for a bump in priority, please reach out the @kylebuch8 or @starryeyez024. Thanks!

castastrophe avatar Feb 18 '21 02:02 castastrophe