patternfly-design icon indicating copy to clipboard operation
patternfly-design copied to clipboard

Published 20 hours ago • verified publisher icon patternfly

Consider improvements to disabled styling - not obvious enough?

Open ncameronbritt opened this issue 5 years ago • 9 comments

Is it possible to use the not allowed cursor style when things like dropdowns or buttons are disabled? I have gotten a complaint that the disabled dropdown style still appears clickable. For this user, it seems that the visual styling alone does not adequately communicate that the item is disabled.

ncameronbritt avatar May 01 '20 19:05 ncameronbritt

cc @mcarrano

mcoker avatar May 05 '20 17:05 mcoker

I'd be OK with making this change. @mceledonia what do you think?

@mcoker Is there a way to do this on a global basis or would it require a change to every component that supports a disabled state?

mcarrano avatar May 05 '20 19:05 mcarrano

@mcarrano I would want to investigate a bit first, but we could probably update this globally.

mcoker avatar May 05 '20 20:05 mcoker

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

stale[bot] avatar Jul 29 '20 04:07 stale[bot]

@mcoker Should I add this to the roadmap?

mcarrano avatar Jul 29 '20 13:07 mcarrano

I've done some initial investigation into this and you can't use cursor: not-allowed; on an element that also has pointer-events: none;. We often set pointer-events: none; on elements that can't be natively disabled. For example, a <button> can be disabled by the browser with the disabled attribute, but a link (<a href="">...</a>) can't be natively disabled, so we disabled its functionality with pointer-events: none;. And when you disable pointer-events, that disables any sort of cursor interactivity with the element, including the ability to set the cursor type`.

If you'd like, we can add it to the roadmap and continue to look into whether there is a workaround or some other way to do this. Though if you don't feel strongly about it, I would be in favor of closing it.

mcoker avatar Jul 29 '20 15:07 mcoker

Thanks @mcoker . I am going to transfer this over to design then and maybe we need to look into the root issue of whether the disabled styling is not obvious enough.

mcarrano avatar Jul 29 '20 19:07 mcarrano

See additional comment on the PF forum here: https://forum.patternfly.org/t/disabled-buttons-styles/391

mcarrano avatar Nov 30 '20 15:11 mcarrano

Need to evaluate what updates we might make and whether those would constitute a breaking change. Adding to the design backlog.

mcarrano avatar Mar 08 '21 21:03 mcarrano

Going to close this for now, but we should consider if this is still a problem after we roll out the new visual theme,

mcarrano avatar Mar 06 '23 19:03 mcarrano