patternfly-design icon indicating copy to clipboard operation
patternfly-design copied to clipboard

Bug - Button - loading spinner hard to see

Open jschuler opened this issue 1 year ago • 1 comments
trafficstars

Describe the problem When the button is both disabled and in loading state, the loading spinner is hard to see. See comparison PF4 and PF5.

How do you reproduce the problem?

<Button variant="secondary" isLoading isDisabled>Secondary</Button>

PF4 https://github.com/patternfly/patternfly-react/assets/869106/f27800b7-0dfd-4fdf-a4f2-71986f283251

PF5 https://github.com/patternfly/patternfly-react/assets/869106/90dbd1d7-78ef-402d-ab8d-5c1a3489211a

What is your environment?

  • OS: macOS
  • Browser: Firefox
  • Version: 115.6.0esr (64-bit)

What is your product and what release date are you targeting? OCM

Any other information?

jschuler avatar Jan 02 '24 18:01 jschuler

cc @andrew-ronaldson @mcoker

tlabaj avatar Jan 25 '24 16:01 tlabaj