patternfly-css icon indicating copy to clipboard operation
patternfly-css copied to clipboard

Add CSS linting

Open guillaumevincent opened this issue 7 years ago • 6 comments

Install ruby scss-lint package. Use the same mechanism as bootstrap.

Fixes https://patternfly.atlassian.net/browse/PTNFLY-2422

guillaumevincent avatar Sep 11 '17 09:09 guillaumevincent

Thanks a lot @guillaumevincent ! I'll test it today

andresgalante avatar Sep 11 '17 12:09 andresgalante

I started small, and will tackle one feature at a time I think travis is not enable right?

The current test (npm test) will raise an error because of the errors in sources/scss/*.scss

guillaumevincent avatar Sep 11 '17 15:09 guillaumevincent

@bleathem this one works for me, can you please review it?

@guillaumevincent thanks a lot, I love it!

andresgalante avatar Sep 18 '17 10:09 andresgalante

@guillaumevincent sorry that it took me so long to loop back to this. Bootstrap 4 beta 2 changed to stylelint and I think it's a good move. What do you think? should we follow it and merge a linter here?

thanks a lot!

andresgalante avatar Oct 24 '17 17:10 andresgalante

let me update the pull request @andresgalante

guillaumevincent avatar Oct 25 '17 08:10 guillaumevincent

Pull request update, I use stylelint now

guillaumevincent avatar Oct 30 '17 10:10 guillaumevincent