angular-patternfly icon indicating copy to clipboard operation
angular-patternfly copied to clipboard

pfFilterResults: Update Results Count Label to PatternFly Design

Open dtaylor113 opened this issue 7 years ago • 3 comments

Here is the current impl.:

image

Here is the Patternfly Design:

image

  • The results count label is left aligned, where it needs to be right aligned
  • When there are active filters the results count label should say "n of m Items"
  • 'Items' can be user defined. Ex: "Virtual Machines" (I think this last part is already implemented, pls verify).
  • When there are no active filters the results count label should say "m Items".
  • Can/Should we make the results count label optional? See #717 & #720. @LHinson, @beanh66

Related Issue: #720

dtaylor113 avatar Feb 23 '18 15:02 dtaylor113

Related open issue in patternfly-design: https://github.com/patternfly/patternfly-design/issues/576

dtaylor113 avatar Feb 23 '18 20:02 dtaylor113

@dtaylor113 I started looking at this issue, and found the following while looking at the current behavior:

  1. Indeed results is currently left aligned. According to this patternfly core issue, the results may need to stay left justified, but maybe @serenamarie125 or @beanh66 can help with this: https://github.com/patternfly/patternfly-design/issues/576

  2. When there are active filters the results will say "n of m items" if the showTotalCountResults option is set to true. (Done in existing codebase)

  3. Items are user defined. I can add a custom label using itemsLabel and itemsLabelPlural. (Done in existing codebase)

  4. When there are no active filters, the results count label says "m items" (Done in existing codebase)

  5. @beanh66 and @LHinson do we want the results count label to be optional? (Need some clarification on this)

issue721results issue721filteredresults

jcaianirh avatar Mar 12 '18 19:03 jcaianirh

Note that the placement of the filter results should always be on the left. This is inconsistent in some of the design pages and we are currently working to clean that up. Please follow this spec for the correct implementation: https://www.patternfly.org/pattern-library/forms-and-controls/filter/#design You'll note that the term "Items" is considered a default, but may be replaced by a more specific term when that makes sense.

mcarrano avatar Aug 30 '18 15:08 mcarrano