angular-patternfly icon indicating copy to clipboard operation
angular-patternfly copied to clipboard

Do not set id="title" in empty state component

Open jeff-phillips-18 opened this issue 7 years ago • 3 comments

We shouldn't use id="title" in the empty state message. That's a really generic ID, and IDs need to be unique on the page.

jeff-phillips-18 avatar Aug 17 '17 13:08 jeff-phillips-18

@jeff-phillips-18 also curious, does it need to be an h1? Is it tied to style? Perhaps could use class="h1" but on a lesser heading.

benjaminapetersen avatar Aug 17 '17 14:08 benjaminapetersen

I don't believe it needs to be an h1. I will look into that as well.

jeff-phillips-18 avatar Aug 17 '17 14:08 jeff-phillips-18

Please see @akieling 's last commit in this Issue.

dtaylor113 avatar Feb 14 '18 18:02 dtaylor113