patternlab-php-core icon indicating copy to clipboard operation
patternlab-php-core copied to clipboard

Published 20 hours ago • verified publisher icon pattern-lab

PatternLabHead and PatternLabFoot missing for the "View All" page of first patternType

Open abangert opened this issue 8 years ago • 3 comments

When I run v2.7.0, PatternLabHead and PatternLabFoot are missing on the "View All" page for whatever is the first pattern type for which such a a view exists.

So, in the demo install, because 00-atoms is first, and has sub-patterns, http://localhost:8080/patterns/00-atoms/index.html is missing the lines that pull in the styleguide CSS, script loader, etc.

This appears to be due to July 12 changes to Builder.php ("processing the header and footer with the patternLoader").

Running with the June 28 commit of Builder.php solved the issue for me.

abangert avatar Jul 28 '16 18:07 abangert

This has been fixed in dev. I'll close this issue once I push a release. Will probably be near the end of the weekend.

dmolsen avatar Jul 28 '16 21:07 dmolsen

Having this issue too, got an ETA on the next release? :)

magnify avatar Nov 24 '16 09:11 magnify

Having this issue after cloning my pattern repo to a new computer. Is there still a fix in the works for this?

EDIT: I realize now why it broke on clone. On my previous machine I had made the change to Builder.php that was pushed to dev in order to fix another problem. https://github.com/pattern-lab/patternlab-php-core/commit/c976fa4cbffac7a67c41df43f47899d09a965a49

davejtoews avatar Sep 19 '17 18:09 davejtoews