patternlab-php-core icon indicating copy to clipboard operation
patternlab-php-core copied to clipboard

Published 20 hours ago • verified publisher icon pattern-lab

Support Array for `patternDir`

Open dmolsen opened this issue 8 years ago • 6 comments

sourceDir (or sourceDirs) should be able to be defined as an array as a package creator may place assets in different locations.

dmolsen avatar May 17 '16 19:05 dmolsen

Been wanting this for awhile; it'd be really helpful! Wouldn't we want an array of source/_patterns/ directories though? An array of sourceDirs could result in multiple _data/data.jsons; how would that get handled, merging?

EvanLovely avatar May 17 '16 21:05 EvanLovely

You're correct. I've updated the title of the ticket to reflect that. Just got focused on the *Dir options that are available and patternDir isn't among them. Guess it needs to be :)

dmolsen avatar May 17 '16 23:05 dmolsen

@EvanLovely need any help tackling this?

sghoweri avatar Nov 02 '17 16:11 sghoweri

@sghoweri Sure! I feel like #35 is a prerequisite though.

EvanLovely avatar Nov 02 '17 16:11 EvanLovely

@EvanLovely Ohhhh sorry - missed that. Need help on that one then?

sghoweri avatar Nov 02 '17 16:11 sghoweri

@sghoweri Would love it! Got a PR started: #152

EvanLovely avatar Nov 02 '17 16:11 EvanLovely