patternlab-php-core icon indicating copy to clipboard operation
patternlab-php-core copied to clipboard

Proposal: Adopt Symfony coding stardards

Open aleksip opened this issue 8 years ago • 5 comments

Pattern Lab PHP uses many Symfony components, so it might make sense to adopt their coding standards. They also have a nice tool, the PHP Coding Standards Fixer, which we could run on our entire PHP codebase.

aleksip avatar Oct 30 '17 17:10 aleksip

^ and could probably use even more Symphony components to further reduce the amount of custom code needing to be maintained.

@aleksip at a high level, what sort of things would adopting Symphony's coding standards change? Please oh please oh please don't say we need to switch back over to using tabs 😜

sghoweri avatar Nov 02 '17 12:11 sghoweri

Love this

EvanLovely avatar Nov 02 '17 15:11 EvanLovely

and could probably use even more Symphony components to further reduce the amount of custom code needing to be maintained

Indeed! Actually, I have some secret plans related to this I'm hoping to advance next week. 😉

Please oh please oh please don't say we need to switch back over to using tabs

Symfony follows PSR-2 which dictates that code MUST use 4 spaces for indenting, not tabs!

aleksip avatar Nov 02 '17 16:11 aleksip

secret plans

😳🤔

EvanLovely avatar Nov 02 '17 16:11 EvanLovely

Not evil ones, I promise! 😈 😄

Just planning to find out if some custom PL code could be replaced with a drop in Symfony replacement with no side effects!

aleksip avatar Nov 02 '17 17:11 aleksip