patternlab-node icon indicating copy to clipboard operation
patternlab-node copied to clipboard

Fully support .html.twig suffix

Open aleksip opened this issue 5 years ago • 10 comments

I am using Pattern Lab Node v3.0.1 on macOS, with Node v10.6.0, using the Twig Edition.

Expected Behavior

Use .html.twig suffix for patterns without any problems.

This style of suffix is advocated in Symfony documentation and is also used by Drupal. In some cases, e.g. when registering layout templates, Drupal expects the layout template to have a .html.twig suffix.

Actual Behavior

Twig template source/rendered HTML not shown in UI, possible other problems.

Steps to Reproduce

Use .html.twig suffix for patterns.

aleksip avatar Jul 10 '19 10:07 aleksip

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] avatar Sep 08 '19 11:09 stale[bot]

Hi there, stale bot!

aleksip avatar Sep 09 '19 07:09 aleksip

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] avatar Nov 08 '19 07:11 stale[bot]

Good old stale bot!

aleksip avatar Nov 08 '19 09:11 aleksip

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] avatar Jan 07 '20 10:01 stale[bot]

I've also been tracking this issue. It is specifically problematic for layouts in Drupal 8 as @aleksip mentioned. I've done some work on a module that automatically derives layouts from a Pattern Lab instance (https://www.drupal.org/project/layouts_pattern_lab), but bug means that some workarounds are required in order to use this with the node version of Pattern Lab.

backlineint avatar Jan 07 '20 13:01 backlineint

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] avatar Mar 07 '20 14:03 stale[bot]

Keeping this one alive...

backlineint avatar Mar 15 '20 23:03 backlineint

Has anyone found a workaround for this issue?

pcate-fls avatar Aug 14 '20 15:08 pcate-fls

@aleksip are you using the extension ‚.html.twig‘ as a „mix and match“ with other files having the ‚.twig‘ as well in the same codebase, or are all of the files strictly named only in one of of those variations?

mfranzke avatar Feb 03 '22 01:02 mfranzke