Jirka Schäfer

Results 35 comments of Jirka Schäfer

I have a overnight celery ob running the code. Here is the Sentry screenshot (switched to plain stripe API call for now). Does this answer your question?

@jleclanche did you see those lines in the liked code above: ``` try: SubscriptionItem.objects.get(id=kwargs["id"]) except SubscriptionItem.DoesNotExist: raise ``` hence, `id` must be given... as far as I'm reading the code,...

lgtm. will you add a test later? and some minors I did see: - it still using the `id` kwarg: ``` if not kwargs.get("id"): raise KeyError("SubscriptionItem Object ID is missing")...

its s3 compatible. I'm using the same s3 storage for another Swiss hosters s3 compatible storage with `django-dbbackup` already. don't see a need to develop anything.