Patrick Thomson

Remove typed-paths interface and use FilePath for everything

2

Though FilePath is very flawed, especially on Windows, typed paths were a failed experiment. They did not actually catch any bugs; the best thing they did was expose some very...

Windows support

12

Nothing about the library ~or executable~ is Unix-specific, so we should support Windows. Creating this issue to track it.

We’ve been using the `pathtype` package to provide type-level distinctions between absolute/relative file/directory paths. Though in theory this is a better solution than plain old `FilePath`, which just [wraps a...

Give Parse effect the ability to parse concurrently

2

Now that #614 is taken care of (or will be soon), we need to reexamine our approach to concurrency. The simplest big win is to change ```haskell data Parse (m...

When we switched to Tasty, we lost hspec’s nice JSON diffs. I worked around this in Semantic.CLI.Spec by using unsafePerformIO to call out to `jd` if available. I have been...

Finish migrating to `pathtype` library.

11

The migration to `pathtype` has been overall a pleasant one—it makes functions much more indicative of their purpose, and it’s caught some bugs (though not serious ones). Right now we’re...

showFailure logic could be simplified

2

_Ported from https://github.com/tree-sitter/haskell-tree-sitter/issues/149_. We could simplify this logic (and the similar logic over :+:s in the generic counterpart) by changing showFailure to take Maybe Node instead of Node. Then we...

_Ported from https://github.com/tree-sitter/haskell-tree-sitter/issues/136._ In Python, true and false are matched by rules of the same name. The TH generates leaf datatypes for these containing Text, like so: ```haskell newtype True...

_Ported from https://github.com/tree-sitter/haskell-tree-sitter/issues/97_. They don’t reflect either the node-types.json file’s declared order or order within the grammar. This is due to aeson using HashMaps to represent objects during JSON parsing,...

_(Forked off of/supersedes https://github.com/tree-sitter/haskell-tree-sitter/issues/263. The below text, originally written by Rob, follows.)_ The TH code currently produces AST datatypes which don’t support diffing: we can’t e.g. replace a subterm with...