Patrick Pichler
Patrick Pichler
I am closing this PR, since it will no longer be necessary moving forward as discussed in the last office hour meeting.
For this we should define something like an `overrideStrategy` flag which defines what to do with the values. Otherwise it will always merge the values. The other question is, if...
This should be fixed with monaco v2 . #351
Related to #337 and #213
There is actually a difference between arguments in `[]` and ``. Arguments in `` are required whereas `[]` are optional. I have no idea how we could make this clearer...
@thschue @AlexsJones what are your opinions on this?
@matthisholleville I see your point, but tbh I would question if the `ai` package should be responsible for parsing/persisting the configuration. That is now encapsulated in the `config` package, which...
That is a good point :slightly_smiling_face: I didn't check the rest of the code yet for candidates to move, as I was just trying to get a quick PoC out...
@matthisholleville I encapsulated every usage of `viper` (besides for caching, I have some suggestion for it, which I will bring up in the slack channel) in the `config` package. Please...
Good idea! I was thinking about it, but was already too far in :sweat_smile: I will open the second PR shortly :slightly_smiling_face: