silverstripe-migrations
silverstripe-migrations copied to clipboard
patricknelson
Ss4 compatibility
Hi
SS4 compatibility upgrade.
I followed steps and considerations from docs on:
- https://docs.silverstripe.org/en/4/upgrading/upgrading_module/
- https://docs.silverstripe.org/en/4/changelogs/4.0.0/
bypassed in most cases solving of any @deprecated 5.0 and TODO parts.
What is working:
- units test - all green
- some basic migrations task works on SS 4.9 as expected
I think that most migration work is done, but because of unit tests low coverage (TODOs in the code) and I don't have yet any more complex migrations tasks (I didn't use it before) please consider it as a beta version for the next release that needs few further tests.
Fixes patricknelson/silverstripe-migrations#15
@patricknelson Think this could be merged? Then I have a PR for Silverstripe 5 support as well
Oh yikes, I totally forgot about this. We sadly haven't even moved to SSv4 yet @wilr have you tested this?
@PawelSuwinski can you correct the spelling namespace? Please use PatrickNelson instead 😄
I can try to do more of an in-depth review later as well but it'll be a free time thing if I can find it, but I am willing to rubber stamp this after confirming that it's versioned out appropriately ~~(i.e. since it relies on some namespaces that aren't present in SS v3 but our deps rely on v3 in this repo, it'll need to point to v4+)~~ and if @wilr is willing to give it a 👍.
Edit: Correction, I see composer.json appears to reference 4.9.0
@PawelSuwinski can you correct the spelling namespace? Please use
PatrickNelsoninstead 😄
Done. Sorry for that :flushed: , it was some bulk insert mispelling I guess.
Sure, I get it! I know it's a bit annoying, but since it's important, I have to point out: It's PatrickNelson, not PatricNelson. Please include the missing k there after the c. 😄
@wilr would you mind giving this a gander really quick too? But yeah will definitely want to go through some in-depth code review on this when I have time to setup a new SS install (goal would be to tackle in the next few weeks but feel free to ping me again within the next month just in case).