Patrick Mann

Results 55 comments of Patrick Mann

What I have gleaned from the code: - `UserService.save` already performs an upsert via `PersistedServiceImpl.save`. No need to change anything there. - Access tokens are mapped to users via `username`....

New rule UI will greatly simplify this https://github.com/Graylog2/graylog-plugin-enterprise/issues/5412

Introducing a new function for regex-removal also resolves https://github.com/Graylog2/graylog2-server/issues/16047. That issue was due to field names being treated as regex patterns when they were not intended as such.

@mpfz0r There is definitely a slowdown between regex and not. But I don't see the same magnitude of performance impact: - 20 `remove_field` calls without regex (for a message of...

`this.props.currentNode.node_id` is undefined here: https://github.com/Graylog2/graylog2-server/blob/33c0f843ff0b450ed2ef7ab98121b52f3a0ed1f6/graylog2-web-interface/src/components/inputs/InputListItem.jsx#L140

I also could only reproduce it on `test-dev-ng`. The backend code for URL white-listing has not changed since 5.2. and API responses look fine. [Custom HTTP Notification](https://github.com/Graylog2/graylog2-server/pull/16758) was recently added...

@linuspahl Did you happen to test on Cloud as well? Looks like we are not passing the `timezone` attribute to Okta. Based on a quick scan of the code, I...

Okta user creation takes a [different code path](https://github.com/Graylog2/graylog-plugin-enterprise/blob/5835580cc2360959c1880f197389df33f44bfbf6/enterprise/src/main/java/org/graylog/plugins/cloud/users/OktaUserManagementServiceImpl.java#L90) from all other auth backends. It uses [UserDetails](https://github.com/Graylog2/graylog2-server/blob/8a41b7fc7cec84a91479558a23fd028ff3d70a01/graylog2-server/src/main/java/org/graylog/security/authservice/UserDetails.java#L30) to persist the information - and that class does not include timezone. So this...

So the requirement is: - titles are not escaped and not interpreted as HTML - descriptions are escaped and interpreted as HTML We can use Freemarker directives to assign plaintext...

I went with your initial suggestion of modifying rendering of titles in the FE. It achieves the desired outcome and doesn't require any changes to templates.