Patrick Pircher

Results 136 comments of Patrick Pircher

That's right. But in tests it looks to work without setting the public asset url. So i wrapped it in an if env !== test

Does `_item` also get reported as unused?

Oh, right. Does it make a difference of its a gts or gjs file?

this? https://github.com/ember-cli/eslint-plugin-ember/pull/2107 mmm, this might be different . But it wil be eager later. Because scope is passes directly, right?

I think the error is correct though. it will be compiled to something like ``` Foo = precompileTemplate(`...`, { scope: [Bar] }) ```

I think it was pretty clear that they will not change `plugin:@typescript-eslint/recommended` behaviour. (Lets discuss this part in #2107)

> > it wilz be compiled to something like > > nay, it's > > ``` > scope: () => ({ Bar }) > ``` hmm, i took another look,...

I looks like that's actually the behaviour it intended to do: > This rule will warn when it encounters a reference to an identifier that has not yet been declared....

i think this can be closed then? as the rule does work correctly as per its own definition

Well, it can then default to old qunit-style. Having the option to easily switch to new style?