Patrick Kusebauch

Results 127 comments of Patrick Kusebauch

I see. Well, I'll leave it up to @dbrumann, but as I alluded to in https://github.com/qossmic/deptrac/issues/916 I don't think shim version of deptrac is actually needed at all. Getting rid...

The `deptrac-shim` version is no longer distributed starting with the 2.0.x line. Please reopen if you encounter this with the new version as well.

You should be able to do this yourself following https://github.com/qossmic/deptrac/blob/main/docs/extending_deptrac.md#layer-collectors, It should have everything you might need to implement this.

This kind of begs the question, what should be the `base` path that this collector should look at in case a relative path to the file is provided?

Yeah, absolutely. What I like about this approach is that it would make it much harder to make cyclic layer dependencies. I have more notes on PHP Config ergonomics as...

@juagarc4 nobody is, feel free to pick it up. :slightly_smiling_face:

This is absolutely a feature. Looks what happens when you "squash" B into the final shape the class will have at runtime: ```php class B { final public function getVO():...

Thinking about it a bit more. Is the argument there that since `final public function getVO(): VO { return new VO($this->generate()); }` is `final` it is always executed in the...

What do you mean by 7.2 compatible? It can analyze PHP 7.2 code. The tool itself is not written in 7.2 compatible PHP though.