basic-ftp icon indicating copy to clipboard operation
basic-ftp copied to clipboard

fix removeDir

Open NakagawaAtsushi opened this issue 3 years ago • 3 comments

NakagawaAtsushi avatar Jan 31 '22 16:01 NakagawaAtsushi

Could you describe your pull request, please?

patrickjuchli avatar Jan 31 '22 16:01 patrickjuchli

@patrickjuchli I think he was trying to fix this upstream bug in my library. Not sure, but I think it's safe to close.

Thanks, keep up the good work ❤️

SamKirkland avatar Jan 31 '22 18:01 SamKirkland

@patrickjuchli I always use this library, thank you.

The removeDir function works correctly if passed absolute path. But, It get error if passed relative path.

So, please describe that correspods only absolute path, or fix source code.

NakagawaAtsushi avatar Feb 01 '22 13:02 NakagawaAtsushi

I've fixed this in a slightly more defensive way, user might also use path like ../, will be out in 5.0.4

patrickjuchli avatar Dec 13 '23 19:12 patrickjuchli