ansible-role-promtail
ansible-role-promtail copied to clipboard
patrickjahns
Make the role not fail when in the check_mode
@patrickjahns right so this is the one that I can confirm is passing with our playbook with and without check_mode
Thanks for submitting the PR - It would be nice to add a test for this to the CI, so we can catch when adding new steps that might fail with check runs.
sure, this one is only to make it not fail terribly ootb.
Let me look at your CI and molecules, because generally it's just a matter of running it with the check_mode: true flag
The first and most obvious test is pretty easy grab - just committed a proposal. I don't think it needs anything else really. What you think ?
@patrickjahns sorry the logging on the failing task is disabled, can you see what is it actually complaining on ?
Restarted the tests - it feels like an intermediary failure / rate limiting. Let's see
Besides that, you can run the test suite locally via tox -e ansible29 -- molecule test -s default - if you set ANSIBLE_DEBUG=true the output should be visible locally
will give tox a go locally, no worries; good opportunity to actually learn the tool I guess
@grzegorznowak - just wanted to reach out if you are still working on this or should this be taken over?
hey @patrickjahns , didn't have time nor opportunity to touch basis with tox yet, so if there's someone who can quickly top up tests and knows where to put stuff, I'd go for it.
@grzegorznowak Are you still interested in bringing this into the role?
hey @patrickjahns thanks for asking! I'm not really able to spend any time on that in the nearest future - been delegated and drawn into something completely different - apologies.