ansible-role-promtail
ansible-role-promtail copied to clipboard
patrickjahns
macOS support
Hey there,
we need to deploy promtail on a fleet of mac-minis to collect some logs from them. here is a proposal on how to support macOS.
sorry for the noise up there, had to switch to my private email and add gpg signature
@mzihlmann thank you for your contribution.
The linter is catching some minor nitpicks - but otherwise looks very good Can you take a look at the one test failure ?
One question - do you have an idea how we could include testing this role on a MacOS target ? I'm otherwise a little concerned if I/we can give a garuantee that the MacOS support of this role is stable. Happy to hear your thoughts
yes testing was also one of my concerns. i think the main blocker would be legal, not technical. We will use this version in production on our servers, but i fully understand if you don't want to get this merged because of testability.
yes testing was also one of my concerns. i think the main blocker would be legal, not technical. We will use this version in production on our servers, but i fully understand if you don't want to get this merged because of testability.
I'd still be happy to merge this, but would not officially support it. Which means if updates break the functionality on Mac , I won't be able to take care of the fixes. If your happy with this 'disclaimer' and open to helping out on the mac support in the long run there is no point of maintaining forks :-) I'd also be open to moving this out of my personal account to plan independent Organisation if there are concerns
I'm only on mobile today - I'll check if we can test this on MacOS somehow with GitHub actions
hmmm legally you're only required to run on Apple hardware. Github seems to support macOS runners. So i think it would be possible.
of course we would help in maintaining it. disclaimer is fine for us. no need to change organization, we don't have such a policy.
@mzihlmann Sorry for the delay - I'll try to get a closer look again this week
no worries, i was just cleaning up my jira and saw that this is still open.
Just went through some open topics - unfortunately I didn't have time to get around this issue. But it is still on my radar