ansible-role-promtail icon indicating copy to clipboard operation
ansible-role-promtail copied to clipboard

Don't use run_once for getting checksums

Open viq opened this issue 2 years ago • 2 comments

https://docs.ansible.com/ansible/latest/user_guide/playbooks_strategies.html#running-on-a-single-machine-with-run-once says that run_once gets executed only on the first host in batch. This makes getting checksums fail for the whole run if that host skips this role for whatever reason.

Fixes https://github.com/patrickjahns/ansible-role-promtail/issues/112

viq avatar Jun 28 '22 09:06 viq

@viq

Thank you very much for the contribution.

I am hesitant to run this tasks on all machines. Especially with a large setup, querying the github API from a lot of hosts (behind NAT) will cause rate limiting/throttling with some hosts failing.

May I suggest to delegate the task to localhost - so they are still only run once?

patrickjahns avatar Jul 19 '22 11:07 patrickjahns

Would you be able to test https://github.com/patrickjahns/ansible-role-promtail/pull/122 in your scenario and see if it also resolves your issue?

patrickjahns avatar Jul 19 '22 11:07 patrickjahns