Patrick Hulce

Results 308 comments of Patrick Hulce

Thanks very much for filing with a simple repro case! That's correct `chrome-launcher` resolves as soon as Chrome has begun listening on the debugging port and not necessarily when a...

> Do you consider the issue I reported to be a bug or normal/expected behavior? I consider it to be expected behavior, but I understand your use case is a...

This seems reasonable to me given our current prioritization of canary over stable 👍

Your repro case is a little unclear @sarduk that error sounds like you're killing Chrome too early while there are things being written in the previous case? The code snippet...

@robert-j-webb you can try giving Lighthouse + puppeteer a try https://github.com/GoogleChrome/lighthouse/blob/master/docs/puppeteer.md#inject-jscss-before-the-page-loads with something like the below? ```js browser.on('targetchanged', async target => { const client = await target.createCDPSession(); await client.send('Security.setOverrideCertificateErrors', {override:...

Yeah a PR would be great, probably belongs over the in lighthouse puppeteer or headless docs :)

@samccone https://bugs.chromium.org/p/chromium/issues/detail?id=721739 AFAICT `Security.setOverrideCertificateErrors` was the feature introduced to address precisely this use case as the flag was deprecated.

> Also, as far as I can tell, the issue about speed-index-metric is related to running lighthouse headlessly, not chrome launcher. @robert-j-webb mind filing a bug over in LH with...

@jonathanong friendly ping on this :)

> If we wanted to expose this to RUM, what would be a sensible security model to do so? The brief justification for why this doesn't expose new information is...