Patrick Dowling

Results 54 comments of Patrick Dowling

Ok. It's possible there's something that needs adapting to the VOR that wasn't included in the original [pull request](https://github.com/mxmxmx/O_C/pull/90) from @Chysn, but honestly I've not been involved in either.

Yeah, from a quick scan it doesn't look like there were any changes to the autotune recently, and I don't recall anyone complaining. So my assumption is that it should...

Awesome, thanks for testing that. My suggestions would be that Shay test if it works on other VOR hardware if he hasn't done so already; it's probably a firmware issue...

The perhaps super-obvious thing would be that it depends on the output range; I'm not totally clear on how that should work is anyway.

It’s not a hardware limitation, but maybe a conceptual one because of the way things are “routed” to generate a clock which drives the channel function. All the channel operations...

Off the top of my head I suspect this might break at least one thing, the hold + turn in the scale editor. I vaguely remember thinking about handling all...

So looking at the source seems to confirm that generating the long-press this way would conflict with the scale editor: The L long press is used, and also there's a...

I'm fairly certain the 14HP PCBs were layouted with Fritzing. Not sure if that's going to be of much use in that regard.

Yeah, I don't end up seeing any need to rename but we can review it. One might argue the module pokes fun at the source -- is it even mentioned...

> Since it can't be undone, I think I'd prefer being explicit about it; there's any number of instructive takes on "Ornament und Verbrechen", I'm happy to turn the "Readme"...