SeoToolkit.Umbraco
SeoToolkit.Umbraco copied to clipboard
patrickdemooij9
Draft for uSync
The initial draft for uSync implementation.
-
[x] Sync meta field- / SEO field values
-
[x] Support language variants
-
[x] Sync SEO settings
For now both handlers are under settings in the uSync dashboard.. not sure why. Events could be added in the respective services to trigger uSync if it's configured to automatically export on updates. But I think this is out of scope for now.
Data in the database doesn't change when disabling SEO settings on a document-type. So not sure how to check for that type of change.
Hi @krebil, Sorry for coming back to this so late. But the work you have done here is amazing! I just gave it a run and it seems to work quite well. I also managed to figure out how to move everything to their own group, so I have commited that.
I did spot an issue where changes aren't tracked correctly. Export everything, change a document type value and export again. It doesn't seem to export the new value. I will see if I can track down what is going wrong there.
when will this PR be merged and release please? this is the missing piece of Seo Toolkit :)
@chrno1209
It's hard to say honestly. uSync is really made to sync umbraco nodes and SeoToolkits stores it's data in a custom table. So a lot of the out of the box functionality doesn't work for this integration.
@patrickdemooij9
Let me know if you need something from me, I'll be happy to jump on a call to squash the last bugs. Alternatively you can catch me at codegarden.
Would love to see this PR merged! uSync is amazing and there is so much Seo data that is handled so smooth with the SeoToolkit.
Just my 2c on this - the uSync functionality really needs to be a separate package, just like a deploy.contrib package would be (if/when we create it!). uSync isn't relevant on Cloud, and having it as a dependency here is too entangled.
