Patrick McDougle
Patrick McDougle
Can we also add the peerDependency that yarn 2 needs to prevent these warnings: > ➤ YN0002: │ @storybook/addon-postcss@npm:2.0.0 doesn't provide webpack (pb2910), requested by css-loader ➤ YN0002: │ @storybook/addon-postcss@npm:2.0.0...
Depending on circumstances, you might also need to install the xcode command line tools as described here: https://apple.stackexchange.com/questions/254380/why-am-i-getting-an-invalid-active-developer-path-when-attempting-to-use-git-a
[IE 11 doesn't have promises](https://caniuse.com/#feat=promises), so you might need to include a promise polyfill to get this to work in IE11.
@jmeas Do you have an opinion on whether this library should include a polyfill or if users should "bring their own"? I might start poking around at this for Hacktoberfest.
One other thing that might be effected by this implementation is "rapidScroll". With intersection observer, we no longer have scroll position, just if it is entering or leaving. I guess...
See [this example](https://codepen.io/patrick-mcdougle/pen/RLZQEe) that illustrates the problem with IntersectionObserver in the above case. I've also opened an [issue](https://github.com/w3c/IntersectionObserver/issues/258) with the W3C to consider this case in the spec, so perhaps...
Does this change the newlines or something? Why did all of the lines change?
You could also solve this in your web server configuration.
An alternate solution might be as I've described in #137 which would allow code to disable the modal (perhaps through events or some other mechanism)