signatory icon indicating copy to clipboard operation
signatory copied to clipboard

Confusion about comment of the "include_original" in Augment

Open sgdy3 opened this issue 2 years ago • 0 comments

Hi, Patrick. Thanks for your code and Document. They really help me a lot. However, I found a little "mistake" in the interpolation about the parameter "include_original" in class Augment. It says that when "include_original" is set to be True, then for each $\Phi(x_i,...,x_{k+i-1})$, original element of the sequence will be included as well. And the output is of the form $(,x_i,\phi(x_i,...,x_{k+i-1}))$. But when I dived into the source code of "Augment", I noticed that it actually be $(,x_{k+i-1},\phi(x_i,..x_{k+i-1}))$. I'm not sure whether this inconsistence is intentional or actually a mistake.

sgdy3 avatar Sep 11 '22 08:09 sgdy3