diffrax icon indicating copy to clipboard operation
diffrax copied to clipboard

Fixup test_term static type checking.

Open tttc3 opened this issue 1 year ago • 2 comments

  • set reportUnnecessaryTypeIgnoreComment=true, as required by the static type "tests" in test_term;

  • remove now redundant, commented out, beatype based tests in test_term;

  • remove all unnecessary type ignore comments from across the codebase.

tttc3 avatar Feb 25 '24 01:02 tttc3

The pre-commit complaints are from bumping the pyright version to 1.1.351. I've had a quick look in eqx.Enumeration to see if this can be handled upstream, but I've drawn a blank; any thoughts?

tttc3 avatar Feb 25 '24 09:02 tttc3

Looks like pyright getting stricter. I've fixed this upsteam on the Equinox dev branch. I'm aiming to do a new release of that fairly shortly, and then we can re-run things here.

patrick-kidger avatar Feb 25 '24 12:02 patrick-kidger

I've removed the pyright bump as this wasn't really related to the purpose of this pull.

tttc3 avatar Apr 21 '24 16:04 tttc3

LGTM! I finally did the new release of Equinox so I'm happy to have this merged. Thank you for the contribution :D

patrick-kidger avatar Apr 21 '24 19:04 patrick-kidger