Patrick Kidger comments

Results 1451 comments of


                                            Patrick Kidger

Failed to compile with Union

What version of typeguard? I think this was a bug in earlier versions of typeguard.

Failed to compile with Union

Thanks! Looks like this is still an outstanding bug in typeguard. Here's a reproducer that doesn't use jaxtyping: ```python import numpy as np from typeguard import typechecked from typing import...

internal `_typeguard` not picked up by `install_import_hook`

This is working as intended! If you want to use typeguard then install it directly as you would normally, pretty much just like you would have done before. The vendored...

Question about `BestSoFar` wrapper and handling of `max_steps`

> First, I'd like to say thank you for this fantastic package! The active development and quality of the documentation are truly appreciated and inspiring. I am a recent user...

Add a `warn_if`

That sounds reasonable to me! I'd be happy to take PR on this.

give users a way to type-query effects, e.g. in eval_shape

FWIW I think there are basically 4 things a user might ask for when abstractly interpreting: 1. output struct + avals 2. jaxpr 3. effects 4. closed-over constants. Right now...

Draft:: Implement box constraints for the Nelder Mead solver, to increase its robustness on messy data where bounds are known.

> Do you think bounded optimization should be a per-solver implementation, or could there be a more abstract formulation that works on any pytree, and could be added to any...

Draft:: Implement box constraints for the Nelder Mead solver, to increase its robustness on messy data where bounds are known.

In terms of API, I'd probably suggest making it a callable all the way, and support nothing else. That would mean something like `optx.minimise(..., move_y=...)` -- although probably let's pick...

Draft:: Implement box constraints for the Nelder Mead solver, to increase its robustness on messy data where bounds are known.

That sounds good to me! Why have separate `_map_with_bounds` and `__call__`, though? (Just make the `__call__` an abstractmethod.) @FFroehlich what do you think? One thing I'm not sure on is...

Strange interaction between Shaped and Union

Oh, this is a mess of Python typing misfeatures and bugs. So `Union[...]` types are only sort-of compatible with `isinstance` checks. In earlier versions of Python they simply errored out;...