Pat O'Callaghan
Pat O'Callaghan
@fivetanley Just to clarify, does `budget` count the number of unique codepaths a deprecation is fired from or is it the total number of times the deprecation warning is called...
@knownasilya @dwickern yep those versions sound reasonable 👍
@GCorbel It looks like it was never published to npm. I got it working by using the following command: ``` npx github:rondale-sc/es5-getter-ember-codemod es5-getter-ember-codemod app/**/*.js ```
I'm also seeing this behaviour on 2.18.2, `@ember/string` works but `@ember/template` does not. It seems the `htmlSafe` API docs still links to a `htmlSafe` within [the string module within ember.js](https://github.com/emberjs/ember.js/blob/v3.1.1/packages/ember-glimmer/lib/utils/string.ts#L59)....
We've also been seeing this a large amount at Intercom. It's actually been happening for a fairly long time. We've an internal issue open to look into it since the...
Yep I've found increasing the `browser_reconnect_limit` resolved the issue somewhat for us. It doesn't solve the root cause but meant livereload didn't die as quickly. https://github.com/ember-cli/ember-cli/issues/9333#issuecomment-726851967
I've just come across the same issue. It seems this is because of the `ignoreLeakingState` option in the config. This looks like it only supports `queryParams` by default even though...
Did a bit more digging and it seems the codemod supports actions using `ObjectMethod` notation but not `FunctionExpression`. ### Works ```js actions: { foo() {} } ``` ### Doesn't work...
Ah it appears this is due to broccoli-asset-rewrite and there is already an [opened issue](https://github.com/ember-cli/broccoli-asset-rewrite/issues/66) and [potential PR fix](https://github.com/ember-cli/broccoli-asset-rewrite/pull/73) over there. Should I leave this open here for visibility?
Are you saying to add that into the **docpad.coffee** or the **.eco** file? Adding the suggested statement runs without any errors in **docpad.coffee** unlike the original query, but when I...