Pat O'Callaghan

Results 42 comments of Pat O'Callaghan

Hey @dwickern, this is an interesting idea. I'd be happy to chat more about it. This would be a breaking change so I wonder if we should try and get...

I'm also seeing this. In my testing it works fine in Embroider's "Safe" mode which is the mode that offers most backwards compatibility with existing Ember apps. The error seems...

Hey @ro0gr 👋, just wondering should we also consider adding the Ember v4 upgrade + v2 Addon migration changes here too as part of this major version bump, or would...

This is also happening in the current ember-source 3.17.0-beta.4 ![image](https://user-images.githubusercontent.com/685034/74282146-8f2e8a80-4d17-11ea-87da-b5480498ceec.png)

I created a corresponding issue in the ember.js repo too https://github.com/emberjs/ember.js/issues/18773

Just posting an update here. There _was_ a bug on the Ember.js side and that was resolved but according to @pzuraq there are still some problems with Ember Data Model...

@knownasilya myself and a colleague [spiked a fix](https://github.com/patocallaghan/ember-data-model-fragments/pull/1) which resolved the initial test case I'd created but it didn't totally solve the issue as we got backtracking assertions in other...

@GuillaumeCisco I wonder if you could create a failing test for the issue you are seeing? Looking at the open issues there are few which look to be related to...

Thanks @pjcarly. When you say 3.28 do you mean ember-source or ember-data? But yeah a reproduction of some sort would be good 👍