pato icon indicating copy to clipboard operation
pato copied to clipboard

broaden "amount"

Open pbuttigieg opened this issue 2 years ago • 2 comments

Currently this only allows for numbers of things that are parts of organisms. We'd like to use that in ontologies like ENVO, but it's currently overspecific due to PATO's history.

It's also very strange that it's under "qualitative" - the definition is decidedly quantitative, which suggests it should be relabelled #65

Perhaps the current class can be relabelled and a superclass that's a more inclusive notion of amounts can be added.

xref: https://github.com/EnvironmentOntology/envo/pull/1346

xref #226

pbuttigieg avatar Aug 16 '22 09:08 pbuttigieg

In fact it's already being used more broadly (and technically incorrectly) by some of our editors (@kaiiam @cmungall may have insight there)

image

pbuttigieg avatar Aug 16 '22 09:08 pbuttigieg

I'm not sure at the moment what the right thing to do with amount is other than work on it in PATO to make it more general?

Those amount of carbon or nitrogen in env material classes are confusing are they ratios or concentrations? I'd presume the latter if so the concentration classes should be used instead. We currently don't have a pattern for ratios.

kaiiam avatar Aug 17 '22 09:08 kaiiam