giternal icon indicating copy to clipboard operation
giternal copied to clipboard

.git.frozen.tgz should NOT be added to repo while freezing

Open ramnathv opened this issue 13 years ago • 1 comments

First off, great work with giternal. It was exactly the tool I was looking for to manage vendoring in a simple, yet flexible manner. The one issue I encountered was the inclusion of .git.frozen.tgz in the main repo, when it is frozen. I believe this is the line responsible for that happening.

https://github.com/patmaddox/giternal/blob/master/lib/giternal/repository.rb#L53

IMHO, I don't think this should be included in the main repo, since it is only to keep track of the history of the dependencies. By including this in the main repo, any push commands push the entire repo along with the history of all the dependencies, which is not desirable.

I managed a workaround by manually calling git checkout .git.frozen.tgz for all the vendored libraries, but a more elegant solution would be to build this into the rubygem.

Let me know your thoughts.

ramnathv avatar Dec 27 '12 22:12 ramnathv

Hi Ramnath. My thinking was that I want to be able to freeze an external AND keep its entire history in the main repo, so that when I check out that revision I'm dealing with the exact same working state that I checked in.

I can see how that might not be desirable though. I guess it should be some sort of configuration but I'm not exactly sure how. Obviously that behavior is something you'd have to turn on, I don't want to break the current default behavior. I'm open to suggestions (and even more open to pull requests :))

patmaddox avatar Jan 14 '13 01:01 patmaddox