Pathikrit Bhowmick

Results 69 comments of Pathikrit Bhowmick

@codingkapoor : Yes that's strange. I need some more information: 1. Can you verify this is not an issue with the akka watcher? You can do this by doing: ```scala...

Thanks for the answer @gmethvin . I still want to rule out a better-files bug because better-files _does_ attach watchers recursively if watching directories: https://github.com/pathikrit/better-files/blob/master/core/src/main/scala/better/files/FileMonitor.scala#L54

I don't have access to a Windows system. Can you give me the full stack trace? The stack trace you posted does not help me figure out from where in...

Thanks for the stack trace. Looks like Windows does not really like walking the directory when it is being unzipped into. Can you try this: ```scala val yourMonitor = new...

I like to keep better-files dependency free but if @gmethvin would like to port that to Scala and better-files, would love to have it in :)

@gmethvin I am fine with JNA dependency in better-files. Alternatively, yes, there is a pluggable interface for monitoring - see the `trait File.Monitor`: https://github.com/pathikrit/better-files/blob/176d13c9f8f436f8aaf7c5946668cdd97713c7e7/core/src/main/scala/better/files/File.scala#L1261-L1289

What do you expect the return type of a `diff(file1, file2)` to return?

@wsargent : Yes, I changed the issue from removing diff from the README (which we should do for now) to actually implement file diff. I think what @jvican suggested makes...

@jvican : Actually I don't know if a String patch is enough. I would prefer an ADT like this ```scala sealed trait Diff object Diff { case class Added(line: String)...

@wsargent : And, that's why this issue is still open.