patchwork icon indicating copy to clipboard operation
patchwork copied to clipboard

Published 20 hours ago • verified publisher icon patched-codes

Fix: skip logging API keys in debug mode

Open Aswinr24 opened this issue 1 year ago • 6 comments

Fixes issue #946

Aswinr24 avatar Oct 11 '24 14:10 Aswinr24

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 11 '24 14:10 CLAassistant

Instead of skipping such inputs can we just replace them with *s may be.

codelion avatar Oct 11 '24 20:10 codelion

Done !

Aswinr24 avatar Oct 12 '24 07:10 Aswinr24

It could be beneficial to treat this like credit card numbers.

Show some part, but mask most. Providing it's long enough to justify doing so without leaking anything usable.

HarryBak avatar Oct 12 '24 13:10 HarryBak

This is a good idea, how about we show the first 4 and last 4 characters as long as the key is >= 24 characters. if it is less than 24 characters we mask with all stars. @Aswinr24

codelion avatar Oct 12 '24 15:10 codelion

Any more changes you suggest?

Aswinr24 avatar Oct 13 '24 05:10 Aswinr24

Is it okay to merge @CTY-git ?

codelion avatar Oct 14 '24 07:10 codelion

LGTM

CTY-git avatar Oct 14 '24 10:10 CTY-git