patchwork icon indicating copy to clipboard operation
patchwork copied to clipboard

Published 20 hours ago • verified publisher icon patched-codes

Get Issue title as well for ResolveIssue Patchflow

Open codelion opened this issue 9 months ago • 3 comments

At the moment we only retrieve the body and comments from an Issue as shown here - https://github.com/patched-codes/patchwork/blob/main/patchwork/common/client/scm.py#L303

If the body is empty and there are no comments it will lead to error while querying the embeddings. Retrieve the title as well from the Issue to avoid this.

codelion avatar May 02 '24 14:05 codelion

Is this open to work?

staru09 avatar Jul 28 '24 20:07 staru09

Yes, this is open to work. Please make sure there are end-to-end test cases or examples others can review when you submit your PR. It can be a link to an example repo like this doesn't have to a test case.

codelion avatar Jul 28 '24 22:07 codelion

@codelion Seems like, we are already getting issue_title in the dictionary returned get_issue_by_id in scm.py which in turn is used by ReadIssues class for reading the issue. I think we can close this issue.

prathamjagga avatar Aug 12 '24 13:08 prathamjagga

@prathamjagga see the comment by @CTY-git here I think it is best if it is at the step level and not in scm.py

codelion avatar Sep 14 '24 02:09 codelion

@codelion can you elaborate it a bit, can't understand @CTY-git 's comment.

prathamjagga avatar Sep 18 '24 12:09 prathamjagga

I just tested it with https://github.com/codelion/example-python/issues/56 I think it is working fine.

codelion avatar Sep 18 '24 13:09 codelion