jquery-nested_attributes icon indicating copy to clipboard operation
jquery-nested_attributes copied to clipboard

Published 20 hours ago • verified publisher icon patbenatar

Turn this into a gem

Open lulalala opened this issue 9 years ago • 14 comments

Are you guys keen on turning this into a gem? Would makes it easier to promote as a substitute to nested_form. I am willing to do it :D

lulalala avatar Jul 13 '15 14:07 lulalala

@lulalala This was on the roadmap a while back, but then https://github.com/nathanvda/cocoon reached a point of maturity where I wasn't able to justify what new/different features we'd be bringing to the table with jquery-nested_attributes...

patbenatar avatar Jul 15 '15 17:07 patbenatar

I liked the fact that jquery-nested_attributes is unobtrusive, which means I won't need a custom version of form_for or link_to for it to work. I think cocoon is not like this?

I am willing to gemify it, so it is just up to you :)

lulalala avatar Jul 16 '15 04:07 lulalala

@lulalala sorry for the delay in getting back to you! Are you thinking we would just use the gem as a means to distribute the JS file, or are there other integrations with Rails you had in mind?

patbenatar avatar Jul 24 '15 23:07 patbenatar

I was thinking in terms of ease of distribution and updates. I think its charm is that I don't need to write code that's obtrusive.

lulalala avatar Jul 26 '15 06:07 lulalala

@lulalala Thoughts on using bower + rails-assets for this?

patbenatar avatar Jul 27 '15 17:07 patbenatar

Oh I think it is an excellent suggestion!

lulalala avatar Jul 31 '15 09:07 lulalala

@lulalala Are you up for preparing this repo for bower submission? Once its up there we can update README to recommend rails-assets as preferred method of installation

patbenatar avatar Jul 31 '15 16:07 patbenatar

Sure, I am not very familiar with the JS-side of things though. Currently I am trying to find out if it allowed using coffeescript as the main file or not.

By the way, what's your standard procedure for generating Javascript from Coffeescript?

lulalala avatar Aug 03 '15 15:08 lulalala

@lulalala @patbenatar hey guys, are there still any advantages of this lib over cocoon gem? I'm out of the context, sorry. The cocoon gem is working 100% ok, especially if they will accept my PR https://github.com/nathanvda/cocoon/pull/301.

@lulalala what is the actual unobtrusive part here?

killthekitten avatar Aug 05 '15 11:08 killthekitten

I really prefer this over cocoon for its simplicity. And I need to get it from bower, so I forked and pushed it: https://github.com/zavan/jquery-nested_attributes http://bower.io/search/?q=jquery-nested_attributes

I kept all of the attributions.

If you'd prefer to push it yourself just tell me and I will unregister it so you can do it :smile:

zavan avatar May 21 '16 04:05 zavan

@killthekitten the fact that cocoon_nested_fields_for is needed.

@zavan Nice, @patbenatar I think we are good to go?

lulalala avatar Mar 13 '18 03:03 lulalala

@lulalala wow this one came out of the past! :)

Where are we good to go with this?

patbenatar avatar Mar 13 '18 20:03 patbenatar

@patbenatar you mentioned that once this is on bower, the readme can be updated to recomment installing it through rails-assets as a gem right?

lulalala avatar Mar 14 '18 00:03 lulalala

Ah right! @zavan thanks for pushing it to bower (and sorry I missed your message 2 years ago 👻). If you'd like to open a PR adding your bower link and rails-assets instructions to the README, I'd happily merge it in!

patbenatar avatar Mar 14 '18 00:03 patbenatar