network-idle-callback icon indicating copy to clipboard operation
network-idle-callback copied to clipboard

Minor package.json issues

Open addyosmani opened this issue 5 years ago • 4 comments

package.json refers to lib/index.js and /lib which don't appear to exist. Perhaps this needs to be updated to refer to index.js in root, @pastelsky?.. :)

image

https://github.com/pastelsky/network-idle-callback/blob/master/package.json#L7

These also appear to be path issues in the prepublish step.

I was trying network-idle-callback for a demo I'm working on and ran into issues with that part of the package today. Any chance of a fix/republish to npm? :)

addyosmani avatar Dec 05 '18 20:12 addyosmani

Hi @addyosmani , The lib/* files are transpiled and published only to npm. Installing it via yarn for eg. will give you this - https://unpkg.com/[email protected]/lib/

I probably already had the lib folder created before publishing so didn't come across this error while building. Let me take a look. But you should be able to pull it off npm and use it just fine.

Also, there is a demo in the www folder that works locally, in case you were looking for one.

pastelsky avatar Dec 06 '18 03:12 pastelsky

Thank you for checking that out :) It was with a local build of the repo that I've seen the above issues.

Is the module vended as CommonJS intentionally? When referencing from unpkg or with an npm install for the browser we see module.exports issues. I can "fix" this by stripping CJS specific lines manually, but wanted to ask in case others ran into this.

addyosmani avatar Dec 08 '18 18:12 addyosmani

@Qawsedrf0501

  • @TonyBogdanov

What?

TonyBogdanov avatar Mar 14 '21 11:03 TonyBogdanov