chrome-webstore-manager icon indicating copy to clipboard operation
chrome-webstore-manager copied to clipboard

CLI exit code always zero

Open DHandspikerWade opened this issue 8 years ago • 3 comments

I am using this project in my build pipeline for a couple of Chrome extensions. Normally this works fine but when it fails the CLI commands still return an exit code of zero.

Would it be possible to return an error code indicating that the command failed? It would increase the usability for people who use the module for scripting.

DHandspikerWade avatar Oct 19 '16 21:10 DHandspikerWade

👍

pastak avatar Oct 26 '16 15:10 pastak

It solves https://github.com/pastak/chrome-webstore-manager/commit/fa7b212d298d8d98fb5c36385bfc6897bcea5206 . So please update to v0.4.1 and try it. Thanks

pastak avatar Oct 26 '16 15:10 pastak

It still uses exit code 0 when the API returns an error such as "Invalid Credentials". It appears to be any of the 4xx error codes.

DHandspikerWade avatar Oct 27 '16 21:10 DHandspikerWade