Pascal Hartig comments

Results 124 comments of


                                            Pascal Hartig

Update annotation processor for Gradle 3

That's great. Thank you! Could you please update your commits to follow the conventional commit message format as linked above? :)

Proguard rules

That seems more like an issue with auto-value than with this library.

Fragment use: You must provide EXTRA_CONFIG when starting the DirectoryChooserActivity

Hey @Hofferic, thanks for the bug report. I'm a bit confused. Does this happen when using the chooser as a fragment or an activity? Since the error message can only...

No support for Marshmallow Runtime Permissions

Yes, there is no support for runtime permissions at the moment. PR welcome!

Fixed callback if DialogFragment called from an other Fragment

Thanks for the patch. I think that's a good idea. Do you think you could also add some tests for around the new behavior?

Fixed callback if DialogFragment called from an other Fragment

@yurezcv Hey, are you still interested in getting this in?

Fixed callback if DialogFragment called from an other Fragment

@yurezcv No worries, I'm in the same boat. :) Just the two things mentioned above, ie. the class cast and removing the unnecessary changes to the XML files.

Fixed callback if DialogFragment called from an other Fragment

ping

Fixed callback if DialogFragment called from an other Fragment

@yurezcv Cool, the rest is okay the way it is. So it's only left to the class cast. :)

Fixed callback if DialogFragment called from an other Fragment

@b3nson I don't have time to pick this up at the moment. Do you want to address the comments? Would be happy to review it.