fido2-net-lib

fido2-net-lib copied to clipboard

Confusing API: MakeAssertionAsync

4

The function https://github.com/passwordless-lib/fido2-net-lib/blob/9ad038b43aa0c37d993cdfd662c03e8d5a08419c/Src/Fido2/IFido2.cs#L16 `IFido2.MakeAssertionAsync()` returns an instance of `VerifyAssertionResult`. This leads to questions and some confusion about how to use it: 1) The return type contains an status and an...

glatzert

Hard-coded Root Cert in source

2

Hi all, I'm reading through as much source and documentation as I can but I'm not understanding the reasoning behind including a hard coded root cert for the Fido metadata...

StuFrankish

Improve Code Quality

2

A quick tidying utilizing .NET8.0 features. - Use HashSizeInBytes - Use .NET 8.0 throw helpers - Use FrozenDictionary to improve lookups - Use required properties - Use throw helpers -...

iamcarbon

Hello, I'm upgrading an application from 3.0.1 to 4.0.0-beta.12 and noticed the CredType property is no longer present in the StoredCredential type (which i mapped to a database table). Also...

g7ed6e

The `AuthenticatorAssertionRawResponse` class has two `byte[]` members `Id` and `RawId`. Both used, although `RawId` is just checked for existence and in tests. As per [MDN](https://developer.mozilla.org/en-US/docs/Web/API/PublicKeyCredential) `Id` is literally the base64url...

Regenhardt

Part of #510

Regenhardt

Separate discussion about point 4. from #426 as requested. > RequestNewCredential takes an AttestationConveyancePreference, but the extensions passed to it include AuthenticationExtensionsDevicePublicKeyInputs which also includes the AttestationConveyancePreference but as a...

Regenhardt

Separate discussion about point 2. from #426 as requested. ## Redundancy On Attestation, the ID of the newly created credential (`RegisteredPublicKeyCredential.Id`) is saved to the database redundantly, once in `StoredCredential.Id`...

Regenhardt

Add support for `largeBlob` extension

1

This PR adds support for the [`largeBlob` extension](https://www.w3.org/TR/webauthn/#sctn-large-blob-extension).

geel9

Hello, I am in the process of adding FIDO2 passwordless / usernameless login to a website. I have run into an issue where if a user has more than one...

kysu1313