fido2-net-lib icon indicating copy to clipboard operation
fido2-net-lib copied to clipboard

Wrap arguments into classes

Open abergs opened this issue 1 year ago • 2 comments

Reason: In order to make arguments more readable and future API changes less likely to cause binary breaking changes to everyone we're moving many arguments into wrapping classes.

In this PR the classes are suffixed with Params, instead of popular Options/Request to avoid adding confusion as those terms are used elsewhere as part of webauthn.

abergs avatar Oct 18 '24 14:10 abergs

I haven't fully reviewed this myself, but pinging @iamcarbon fyi.

abergs avatar Oct 18 '24 14:10 abergs

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.72%. Comparing base (72f5a36) to head (fa91b0f).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   74.62%   74.72%   +0.10%     
==========================================
  Files         101      103       +2     
  Lines        2719     2730      +11     
  Branches      464      464              
==========================================
+ Hits         2029     2040      +11     
  Misses        581      581              
  Partials      109      109              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 18 '24 14:10 codecov-commenter

@iamcarbon Please feel free to feedback on this.

abergs avatar Oct 28 '24 15:10 abergs