fido2-net-lib icon indicating copy to clipboard operation
fido2-net-lib copied to clipboard

conformance 1.7.20 4

Open abergs opened this issue 1 year ago • 2 comments

This is based on #456 and results in a 100% pass on the v1.7.20-4 tool.

image

  • FIDO Conformance Tools v1.7.15 fixes
  • Json serialization fix
  • Unit test fix
  • tokenbindig, AppId, UVP
  • unit test fix (tokenbinding dto parsing)
  • fix azure pipeline
  • Improve trustanchor test coverage
  • TestPackedttestationAsyncFailTrustAnchorOnRootCertInTrustPath only works on Windows
  • Do not make this private
  • Keep Tokenbinding around
  • Update AuthenticatorAssertionResponse.cs
  • Added XML comments to requestTokenBinding

abergs avatar Jul 16 '24 08:07 abergs

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 67.39130% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.79%. Comparing base (cb71a15) to head (97762f6). Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
Src/Fido2/TokenBindingDto.cs 20.00% 6 Missing and 2 partials :warning:
...ls/Objects/AuthenticationExtensionsClientInputs.cs 0.00% 2 Missing :warning:
Src/Fido2/AuthenticatorAttestationResponse.cs 50.00% 1 Missing and 1 partial :warning:
Src/Fido2.Models/CredentialCreateOptions.cs 50.00% 1 Missing :warning:
Src/Fido2/AuthenticatorAssertionResponse.cs 66.66% 0 Missing and 1 partial :warning:
Src/Fido2/TrustAnchor.cs 94.11% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   73.95%   74.79%   +0.84%     
==========================================
  Files          98      102       +4     
  Lines        2638     2742     +104     
  Branches      446      464      +18     
==========================================
+ Hits         1951     2051     +100     
+ Misses        586      582       -4     
- Partials      101      109       +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 16 '24 08:07 codecov-commenter

@aseigler See mentions. If you don't have time too look at them at the moment I might move those changes to a secondary PR wand wait for your review, while still landing some of these fixes.

abergs avatar Jul 16 '24 09:07 abergs