fido2-net-lib icon indicating copy to clipboard operation
fido2-net-lib copied to clipboard

Update to .NET 8

Open joegoldman2 opened this issue 1 year ago • 3 comments

Fixes #419. Fixes #497.

joegoldman2 avatar Feb 15 '24 06:02 joegoldman2

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b597d18) 74.44% compared to head (4a34cc8) 74.45%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   74.44%   74.45%           
=======================================
  Files          99       98    -1     
  Lines        2677     2666   -11     
  Branches      455      445   -10     
=======================================
- Hits         1993     1985    -8     
+ Misses        580      578    -2     
+ Partials      104      103    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 15 '24 06:02 codecov-commenter

@iamcarbon Since you've been prepping for .net 8, please feel free to do a review. If no comments I'll bring this.

Thanks for the contribution @joegoldman2

abergs avatar Feb 16 '24 13:02 abergs

Looks good here! Thanks @joegoldman2

This also enables us to use frozen collections, collection builders, init only members (that can remain serializable by System.Text.Json), required properties, and some other nice things from .NET 8.0.

iamcarbon avatar Feb 17 '24 00:02 iamcarbon