fido2-net-lib icon indicating copy to clipboard operation
fido2-net-lib copied to clipboard

Minor inconsistency between AllowCredentials and ExcludeCredentials

Open MichaelGrafnetter opened this issue 4 years ago • 1 comments

Hi, there is a tiny inconsistency in the API:

public class CredentialCreateOptions : Fido2ResponseBase
{
    ...
    public List<PublicKeyCredentialDescriptor> ExcludeCredentials { get; set; }
}

vs.

public class AssertionOptions : Fido2ResponseBase
{
    ...
    public IEnumerable<PublicKeyCredentialDescriptor> AllowCredentials { get; set; }
}

I therefore propose changing AllowCredentials to List<PublicKeyCredentialDescriptor>. This should not be a breaking change, as List is still IEnumerable.

MichaelGrafnetter avatar Oct 13 '20 07:10 MichaelGrafnetter

Likely I am missing it... I see ExlcludeCredentials in the library, but what happened to AllowCredentials? I am able to register with Windows and Android without issue... but on iOS I have come to understand that I need to set AllowCredentials according to this post: https://stackoverflow.com/a/65281690/1819403

See: image

6Hat avatar Apr 28 '21 12:04 6Hat