fido2-net-lib
fido2-net-lib copied to clipboard
Minor inconsistency between AllowCredentials and ExcludeCredentials
Hi, there is a tiny inconsistency in the API:
public class CredentialCreateOptions : Fido2ResponseBase
{
...
public List<PublicKeyCredentialDescriptor> ExcludeCredentials { get; set; }
}
vs.
public class AssertionOptions : Fido2ResponseBase
{
...
public IEnumerable<PublicKeyCredentialDescriptor> AllowCredentials { get; set; }
}
I therefore propose changing AllowCredentials
to List<PublicKeyCredentialDescriptor>
. This should not be a breaking change, as List
is still IEnumerable
.
Likely I am missing it... I see ExlcludeCredentials in the library, but what happened to AllowCredentials? I am able to register with Windows and Android without issue... but on iOS I have come to understand that I need to set AllowCredentials according to this post: https://stackoverflow.com/a/65281690/1819403
See: