Pascal Welsch

Results 154 comments of Pascal Welsch

Sounds useful. Although `deliverLatestToView` doesn't make a lot of sense because it's only one event. `deliverToView` should be enough. Alternatively you could use the new `sendToView()` method ```java categoryService.getMainCategories() .subscribe(categories...

ThirtyInch can nothing do against process death and has no APIs to restore the state. It was developed by assuming that the process rarely gets killed which is true for...

@vRallev I fear that the `TiPresenter` ends up being a subset of `Activity` with similar callback methods and similar lifecycle but surviving orientation changes. While this could be a reasonable...

Work started based on #50. Not finished yet but you can have a look: branch [feature/persist-presenter](https://github.com/grandcentrix/ThirtyInch/tree/feature/persist-presenter)

I provided a failing test which is `sendToView_withView_beforeInRunningState_executesAction_without_executor`. As I said it is a multithreading problem. I have no idea how to stop the thread before line `moveToState(State.VIEW_ATTACHED, false);` where...

I came to the conclusion I should remove the "multithreading" unit test. Unit test shouldn't mimic multi threading scenarios. ### Flip mView assignment with observer notifications Changing the `mView` assignment...

`getViewOrThrow()` never returns `null` in `onAttachView`. This lint warning could hint to use the parameter `view` instead of `getViewOrThrow()`

currently not, but we are working on it!

I started implementing a sample (based on googles [TODO-MVP sample](https://github.com/googlesamples/android-architecture)). So far I did only one Activity but it should give you an idea: https://github.com/passsy/thirtyinch-sample

Here is a sample implementation https://github.com/passsy/thirtyinch-sample/tree/todo-mvp-thirtyinch/todoapp/app/src/main/java/com/example/android/architecture/blueprints/todoapp/addedittask