passff icon indicating copy to clipboard operation
passff copied to clipboard

New icon for passff. Not visible for many dark themes.

Open raven2cz opened this issue 3 years ago • 1 comments

I already wrote this issue and it was closed as upstream issue. Please check this issue correct way. Actual standard firefox themes cause that the icon is not visible anymore, because it has exact same color as standard theme.

passFF-icon-invisble

Your passff icon is on right side from vimium plugin. If for example vimuim plugin icon haven't these problems why your icon has it? (if it is a upstream issue?)

Please check correctly it and change the colors according these problems. Dark themes are much more used against light themes. Or add some possibility to change it by user configuration of your plugin, some switcher light/dark/auto. Thanks for help.

raven2cz avatar Nov 25 '21 18:11 raven2cz

I just checked several dark themes and didn't find any for which the background color exactly agrees with the icon color. So I don't think that this is a big issue. You can solve this by adding transparency to the icon. Feel free to make a PR with this kind of change. I currently don't have time to deal with it, sorry.

tuxor1337 avatar Nov 25 '21 18:11 tuxor1337

Confirm (Firefox 109.0): passff

Alexey104 avatar Jan 24 '23 03:01 Alexey104

Fixed in 1.14.1

tuxor1337 avatar Feb 12 '23 11:02 tuxor1337

Confirm, thank you!

Alexey104 avatar Feb 12 '23 11:02 Alexey104