passbolt_help icon indicating copy to clipboard operation
passbolt_help copied to clipboard

Improvement suggestions for SLES setup instructions

Open dirkmueller opened this issue 1 year ago • 0 comments

Following the instructions at https://passbolt.com/docs/hosting/install/ce/sles/ I have the following suggestions:

avoid use of wget

wget is not a standard installed tool in the minimal system. you can achieve pretty much the same outcome by using curl -O instead, so

-wget https://download.passbolt.com/ce/installer/passbolt-repo-setup.ce.sh
+curl -O https://download.passbolt.com/ce/installer/passbolt-repo-setup.ce.sh

then, the repo-setup script is using which(1) to determine whether zypper or other tools are available. which is sort of deprecated and might not be installed in really very minimal systems. There is an equivalent bash builtin, which would work the same way:

--- passbolt-repo-setup.ce.sh-20240503  2024-05-03 11:46:47.838522592 +0000
+++ passbolt-repo-setup.ce.sh   2024-05-03 11:49:06.370671699 +0000
@@ -141,13 +141,13 @@
       then
           CODENAME="focal"
       fi
-  elif which zypper > /dev/null 2>&1
+  elif test -e "$(type -p zypper)" > /dev/null 2>&1
   then
       PACKAGE_MANAGER=zypper
-  elif which dnf > /dev/null 2>&1
+  elif test -e "$(type -p dnf)" > /dev/null 2>&1
   then
       PACKAGE_MANAGER=dnf
-  elif which yum > /dev/null 2>&1
+  elif test -e "$(type -p yum)" > /dev/null 2>&1
   then
       PACKAGE_MANAGER=yum
   else
@@ -349,4 +349,4 @@

dirkmueller avatar May 03 '24 11:05 dirkmueller