passbolt_api icon indicating copy to clipboard operation
passbolt_api copied to clipboard

Saving a tag without changes deletes it

Open samuel-apps opened this issue 5 years ago • 2 comments

Saving a tag without changes deletes it

  • Passbolt Version: 2.12.0
  • Platform and Target: -- CentOS Linux release 8.1.1911 (Core) -- NGINX 1.14.2 -- mysql Ver 15.1 Distrib 10.3.17-MariaDB, for Linux (x86_64) using readline 5.1 -- PHP 7.2.11 (cli) (built: Oct 9 2018 15:09:36) ( NTS )

What you did

I edit a tag, don't change anything, and press save

What happened

The tag seems to have disappeared entirely and immediately. Inspecting any passwords which previously had the tag in question, shows that they no longer have the tag in question.

What you expected to happen

I expected pretty much the same thing would happen as when i pressed cancel. From the end user's point of view anyway. But I would argue that it's a flaw in the API that it blatantly deletes a tag when you make a PUT request with a specific payload.

samuel-apps avatar Feb 13 '20 15:02 samuel-apps

Just came here to say, haha told you we shouldn't have switched ;-)

supergoudvis116 avatar Feb 13 '20 15:02 supergoudvis116

It seems kind of like whenever a tag is edited, the API creates a new tag... I suppose it might be an issue if it immediately tried to create the same tag again?

samuel-apps avatar Feb 13 '20 16:02 samuel-apps

Sorry for the delay to answer. It seems to have been fixed. Feel free to reopen if the bug persists.

cedricalfonsi avatar Nov 29 '22 09:11 cedricalfonsi