go-passbolt-cli icon indicating copy to clipboard operation
go-passbolt-cli copied to clipboard

Fetch Secrets alongside resources if required

Open speatzle opened this issue 2 years ago • 3 comments

speatzle avatar Jan 27 '23 10:01 speatzle

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 27 '23 10:01 CLAassistant

Hi @speatzle I looked at your changes here. I have noticed, that you added a condition, where you check, if users set secret columns, and then you load this values over new function in the api. In your condition, you're using lowercase of column names. In the help description of switch -c all column names are in camel case. I think users will be guided by the help and will use camel case too.

AndyPilz avatar Feb 19 '23 00:02 AndyPilz

@PiMaDaum hi, thanks for the tip, this was just a rough proof of concept and i forgot to strings.lower case the input. but i will need to redo this PR based on your filter PR's Changes anyway.

speatzle avatar Feb 22 '23 18:02 speatzle